Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add example for having separate pvc for loki, using helm #2358

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Conversation

rille111
Copy link
Contributor

What this PR does / why we need it:

It updates the docs with an example for a persistent storage for the logs.

Which issue(s) this PR fixes:

Fixes no issue, but helps other developers not as well versed in k8s and helm.

Special notes for your reviewer:

Checklist

  • [x ] Documentation added

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020

Codecov Report

Merging #2358 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2358      +/-   ##
==========================================
+ Coverage   61.50%   61.51%   +0.01%     
==========================================
  Files         160      160              
  Lines       13534    13534              
==========================================
+ Hits         8324     8326       +2     
+ Misses       4585     4584       -1     
+ Partials      625      624       -1     
Impacted Files Coverage Δ
pkg/logql/evaluator.go 92.88% <0.00%> (+0.40%) ⬆️

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After signing the CLA, looks good to me.

@cyriltovena cyriltovena merged commit 99604a5 into grafana:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants