logstash code refactor and doc improvements #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2410 +/- ##
==========================================
- Coverage 61.67% 61.64% -0.03%
==========================================
Files 160 160
Lines 13577 13577
==========================================
- Hits 8373 8370 -3
- Misses 4581 4584 +3
Partials 623 623
|
cyriltovena
approved these changes
Jul 24, 2020
cmd/logstash/README.md
Outdated
| @@ -43,7 +45,6 @@ git checkout tags/v7.6.2 | |||
| export LOGSTASH_PATH=`pwd` | |||
| export GEM_PATH=$LOGSTASH_PATH/vendor/bundle/jruby/2.5.0 | |||
| export GEM_HOME=$LOGSTASH_PATH/vendor/bundle/jruby/2.5.0 | |||
| ./gradlew assemble | |||
There was a problem hiding this comment.
That what did the trick for me. I needed the jar to run the plugin. It’s also documented.
There was a problem hiding this comment.
The jar is required if we are doing Java development. But Ruby based development should not require this. Anyways I will add it back.
There was a problem hiding this comment.
The plugin could not run for me without this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
logstash code refactor and doc improvements.