Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more precisions on the docker driver installed on the daemon. #2435

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

cyriltovena
Copy link
Contributor

It will work only for new containers, as explained by one of our users in the mailing list.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

It will work only for new containers, as explained by one of our users in the mailing list.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2435 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2435      +/-   ##
==========================================
+ Coverage   62.70%   62.72%   +0.01%     
==========================================
  Files         162      162              
  Lines       13850    13850              
==========================================
+ Hits         8685     8687       +2     
+ Misses       4488     4487       -1     
+ Partials      677      676       -1     
Impacted Files Coverage Δ
pkg/logql/evaluator.go 92.47% <0.00%> (-0.41%) ⬇️
pkg/promtail/targets/file/tailer.go 78.40% <0.00%> (+4.54%) ⬆️

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@owen-d owen-d merged commit 2d5b6b5 into grafana:master Jul 29, 2020
@githubcdr githubcdr mentioned this pull request May 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants