set __path__ correctly in promtail config #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__path__ is now expected to be a `glob` match, not a directory. In k8s the "glob" expression needed is just the exact file path of the container log, which is `/var/log/pods/<podUID>/<container_name>/0.log`
tomwilkie
approved these changes
Jan 29, 2019
MichelHollands
pushed a commit
that referenced
this pull request
Jan 16, 2023
**What this PR does / why we need it**: The Changelog diff between the two commits is grafana/dskit@3e308a4...7242706 ``` * [CHANGE] Cache: Switch Memcached backend to use `github.com/grafana/gomemcache` repository instead of `github.com/bradfitz/gomemcache`. #248 * [ENHANCEMENT] Add cache, gate and stringsutil packages. #239 * [ENHANCEMENT] Cache: add Redis support. #245 * [ENHANCEMENT] Cache: Add the ability to use a custom memory allocator for cache results. #249 * [BUGFIX] Memberlist: fix crash when methods from `memberlist.Delegate` interface are called on `*memberlist.KV` before the service is fully started. #244 ``` **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](../CONTRIBUTING.md) guide (**required**) - N/A Documentation added - N/A Tests updated - N/A `CHANGELOG.md` updated - N/A Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
jeschkies
pushed a commit
to jeschkies/loki
that referenced
this pull request
Jan 18, 2023
**What this PR does / why we need it**: The Changelog diff between the two commits is grafana/dskit@3e308a4...7242706 ``` * [CHANGE] Cache: Switch Memcached backend to use `github.com/grafana/gomemcache` repository instead of `github.com/bradfitz/gomemcache`. grafana#248 * [ENHANCEMENT] Add cache, gate and stringsutil packages. grafana#239 * [ENHANCEMENT] Cache: add Redis support. grafana#245 * [ENHANCEMENT] Cache: Add the ability to use a custom memory allocator for cache results. grafana#249 * [BUGFIX] Memberlist: fix crash when methods from `memberlist.Delegate` interface are called on `*memberlist.KV` before the service is fully started. grafana#244 ``` **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](../CONTRIBUTING.md) guide (**required**) - N/A Documentation added - N/A Tests updated - N/A `CHANGELOG.md` updated - N/A Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__path__is now expected to be aglobmatch, not a directory. In k8s the "glob" expression needed is just the exact file path of the container log, which is `/var/log/pods//<container_name>/0.log