Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tanka.md with steps for using k8s-alpha lib #2528

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Aug 20, 2020

Our transitive dependencies now require the alpha library 😭 .

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@oddlittlebird oddlittlebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits.

docs/sources/installation/tanka.md Outdated Show resolved Hide resolved
docs/sources/installation/tanka.md Outdated Show resolved Hide resolved
docs/sources/installation/tanka.md Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2020

Codecov Report

Merging #2528 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2528      +/-   ##
==========================================
- Coverage   63.57%   63.56%   -0.02%     
==========================================
  Files         163      163              
  Lines       14305    14305              
==========================================
- Hits         9095     9093       -2     
- Misses       4498     4499       +1     
- Partials      712      713       +1     
Impacted Files Coverage Δ
pkg/logql/evaluator.go 92.47% <0.00%> (-0.41%) ⬇️

owen-d and others added 2 commits August 20, 2020 16:54
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
@owen-d owen-d merged commit 5fcd399 into master Aug 20, 2020
@owen-d owen-d deleted the owen-d-patch-2-1 branch August 20, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants