cleanup boltdb files in queriers during startup/shutdown #2558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Queriers do not use existing boltdb files when they receive a query for a new table(never served queries for it since startup) and we do not remove boltdb files when queriers stop which means unwanted files would be lying around.
This PR removes files from the cache directory during graceful shutdown or during startup if it didn't get to remove them for some reason.
Ideally, it would be good to reuse those files but the files could be stale and we would have to sync them first with the store which would add up to startup delay. We can handle this in future incremental changes.