-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback_formats for timestamp stage #2615
Add fallback_formats for timestamp stage #2615
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2615 +/- ##
==========================================
- Coverage 63.13% 61.52% -1.61%
==========================================
Files 169 169
Lines 15018 13154 -1864
==========================================
- Hits 9481 8093 -1388
+ Misses 4784 4322 -462
+ Partials 753 739 -14
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@slim-bean if you're ok with the name of the property I let you merge it.
@aminjam in the meantime can you sign the CLA ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR!
Hi @aminjam would love to merge this but we need to get the CLA "signed". If you've "signed" it and it fails, this is usually because the email address in your commit doesn't match any in your github account. Fixing this usually requires amending the commit with an email address you have in github and force pushing back to your branch. Let me know if you have any questions or problems! |
Thank you all for your patience. I have been working through getting the authorization to sign the CLA. I hope to have more updates on the progress this week. |
590e795
to
d05a4ab
Compare
Nice thanks again @aminjam! |
Which issue(s) this PR fixes:
Fixes #2590
Checklist