Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds prometheus ruler routes #2650

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Sep 21, 2020

Adds a couple passthrough routes for Prometheus API compatibility regarding current rule evaluation status.

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #2650 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2650      +/-   ##
==========================================
+ Coverage   61.16%   61.18%   +0.01%     
==========================================
  Files         172      172              
  Lines       13358    13360       +2     
==========================================
+ Hits         8171     8174       +3     
  Misses       4437     4437              
+ Partials      750      749       -1     
Impacted Files Coverage Δ
pkg/loki/modules.go 3.77% <0.00%> (-0.03%) ⬇️
pkg/promtail/targets/file/filetarget.go 63.38% <0.00%> (-0.71%) ⬇️
pkg/canary/comparator/comparator.go 78.18% <0.00%> (+1.81%) ⬆️

@owen-d owen-d merged commit 9e85757 into grafana:master Sep 21, 2020
owen-d added a commit that referenced this pull request Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants