Bypass sharding middleware when a query can't be sharded. #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2709 +/- ##
=======================================
Coverage 61.37% 61.37%
=======================================
Files 173 173
Lines 13444 13446 +2
=======================================
+ Hits 8251 8253 +2
+ Misses 4440 4439 -1
- Partials 753 754 +1
|
cyriltovena
added a commit
to cyriltovena/loki
that referenced
this pull request
Oct 21, 2020
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this issue while working on LogQL v2.
Need to rebase to this once merged to make some new cool expr working with the frontend.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com