Allows service targetPort modificaion #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2789 +/- ##
==========================================
- Coverage 61.42% 61.39% -0.03%
==========================================
Files 177 177
Lines 14373 14373
==========================================
- Hits 8828 8825 -3
- Misses 4738 4740 +2
- Partials 807 808 +1
|
bewiwi
changed the title
bewiwi
force-pushed
the
fix/helm/ingress_service_port
branch
from
60c6ada to
e69ac90
Compare
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For now, it's appears that It's not possible to redirect request to loki service to a sidecar to do some HTTP authentication.
In the values.yml we have an example of sidecar to do a reverse proxy. We can add
extraPortsthat refer to this sidecar but it's not possible to update the targetPort in the loki service definition because the port name is hardcoded (http-metrics).In conclusion, we can't use the sidecar as a proxy for requests coming to this service.
This PR will allow the modification of the loki targetPort to be able to define an other one
Special notes for your reviewer:
Nothing special, just move an hardcoded value to
values.yamlChecklist