Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: improve the helm upgrade section #2811

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Conversation

slim-bean
Copy link
Collaborator

No description provided.

@achatterjee-grafana
Copy link
Contributor

@docs, looking at this PR now.

Copy link
Contributor

@achatterjee-grafana achatterjee-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a change. Otherwise looks good.

@@ -58,24 +58,16 @@ There are three places we have hard coded the schema definition:

Helm has shipped with the same internal schema in the values.yaml file for a very long time.

If you are providing your own values.yaml file then there is no _required_ action because you will already have a fixed schema version.
If you are providing your own values.yaml file then there is no _required_ action because you will already have a schema definition.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "will"

@slim-bean slim-bean merged commit 1626643 into master Oct 26, 2020
@slim-bean slim-bean deleted the update-upgrade-guide branch October 26, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants