Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix quoting issues in test output when building with Go 1.15 #2836

Merged
merged 1 commit into from
Oct 29, 2020
Merged

tests: fix quoting issues in test output when building with Go 1.15 #2836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/logentry/stages/drop_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ func Test_validateDropConfig(t *testing.T) {
config: &DropConfig{
OlderThan: &dropInvalidDur,
},
wantErr: fmt.Errorf(ErrDropStageInvalidDuration, dropInvalidDur, "time: unknown unit y in duration 10y"),
wantErr: fmt.Errorf(ErrDropStageInvalidDuration, dropInvalidDur, "time: unknown unit \"y\" in duration \"10y\""),
},
{
name: "Invalid Config",
Expand Down
2 changes: 1 addition & 1 deletion pkg/logentry/stages/metrics_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ func Test(t *testing.T) {
IdleDuration: &metricTestInvalidIdle,
},
},
errors.Errorf(ErrInvalidIdleDur, "time: unknown unit f in duration 10f"),
errors.Errorf(ErrInvalidIdleDur, "time: unknown unit \"f\" in duration \"10f\""),
},
"valid": {
MetricsConfig{
Expand Down