Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: fix regression in tanka jsonnet #2899

Merged
merged 1 commit into from
Nov 9, 2020
Merged

gateway: fix regression in tanka jsonnet #2899

merged 1 commit into from
Nov 9, 2020

Conversation

halcyondude
Copy link
Contributor

@halcyondude halcyondude commented Nov 9, 2020

What this PR does / why we need it:

Seeing the following when importing loki...

evaluating jsonnet: RUNTIME ERROR: {snip}everquoteinc/loki-du/tanka/vendor/loki/gateway.libsonnet:97:5-6 Unexpected: "$" while parsing field definition

Special notes for your reviewer:

Related to:

#2852
cb383d6

Seeing the following when importing loki...

evaluating jsonnet: RUNTIME ERROR: {snip}everquoteinc/loki-du/tanka/vendor/loki/gateway.libsonnet:97:5-6 Unexpected: "$" while parsing field definition

Related to:

#2852
cb383d6
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 80539a2 into grafana:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants