-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boltdb shipper query readiness #2911
Merged
sandeepsukhani
merged 4 commits into
grafana:master
from
sandeepsukhani:boltdb-shipper-query-readiness
Nov 18, 2020
Merged
Boltdb shipper query readiness #2911
sandeepsukhani
merged 4 commits into
grafana:master
from
sandeepsukhani:boltdb-shipper-query-readiness
Nov 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Nov 13, 2020
cyriltovena
reviewed
Nov 13, 2020
cyriltovena
reviewed
Nov 13, 2020
sandeepsukhani
force-pushed
the
boltdb-shipper-query-readiness
branch
from
November 17, 2020 13:42
289c1cc
to
0e007a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2911 +/- ##
==========================================
+ Coverage 61.77% 61.81% +0.03%
==========================================
Files 182 182
Lines 14772 14863 +91
==========================================
+ Hits 9126 9187 +61
- Misses 4811 4830 +19
- Partials 835 846 +11
|
cyriltovena
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think you just need to tm.Stop line 70 in the table_manager.go
sandeepsukhani
force-pushed
the
boltdb-shipper-query-readiness
branch
from
November 18, 2020 11:45
6320ea2
to
4cfe998
Compare
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* fix calling of stop method on series store Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * do not embed fetcher in seriesStore to avoid errors Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Special notes for your reviewer:
Checklist