Fixes iota unexpected behaviour with bytes for chunk encoding. #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introducing incompatibilities since iota with bytes starts at 2. Seems like a weird conversion between iota int and byte. This can currenlty corrupt chunks, and previous chunks are not decodable. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Well you just helped me figured out what was going on, basically the iota needs to be in his own const() or at the top. |
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
@sandeepsukhani check this out now. |
Closed
slim-bean
pushed a commit
that referenced
this pull request
Dec 10, 2020
* Fixes iota unexpected behaviour with bytes for chunk encoding. This was introducing incompatibilities since iota with bytes starts at 2. Seems like a weird conversion between iota int and byte. This can currenlty corrupt chunks, and previous chunks are not decodable. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * With iota correclty this time. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> (cherry picked from commit fa7ea9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introducing incompatibilities since iota with bytes starts at 2.
Seems like a weird conversion between iota int and byte.
This can currently corrupt chunks, and previous chunks are not decodable. New chunk are decodable because we encode/decode with the wrong value, this is also why tests are passing.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com