Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove helm init #2967

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Remove helm init #2967

merged 1 commit into from
Nov 23, 2020

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Nov 20, 2020

As helm v2 is EOF, I removed the commands only present in helm v2.

Fixes #2966

Signed-off-by: Christian Zunker christian.zunker@codecentric.cloud

What this PR does / why we need it:

This PR remove helm v2 specific commands which break the Makefile usage with helm v3.
As helm v2 is EOF I just removed the commands and didn't test which helm version is used.

Checklist

  • [-] Documentation added
  • [-] Tests updated

@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #2967 (8d1c45c) into master (a62f81f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2967   +/-   ##
=======================================
  Coverage   61.75%   61.76%           
=======================================
  Files         182      182           
  Lines       14866    14866           
=======================================
+ Hits         9181     9182    +1     
  Misses       4838     4838           
+ Partials      847      846    -1     
Impacted Files Coverage Δ
pkg/querier/queryrange/downstreamer.go 95.29% <0.00%> (-2.36%) ⬇️
pkg/promtail/targets/file/filetarget.go 66.19% <0.00%> (+2.11%) ⬆️

@czunker czunker force-pushed the helm_v3 branch 5 times, most recently from f9e7a05 to 8d1c45c Compare November 20, 2020 14:03
As helm v2 is EOF, I removed the commands only present in helm v2.

Fixes grafana#2966

Signed-off-by: Christian Zunker <christian.zunker@codecentric.cloud>
@czunker
Copy link
Contributor Author

czunker commented Nov 20, 2020

This is currently limited to the Makefile. I saw helm v2 is used in the CI. I managed it to get helm v3 running in the CI, but ct does not work:

#!/bin/bash -eo pipefail
ct lint --chart-dirs=production/helm --config=production/helm/ct.yaml
ct install --build-id=${CIRCLE_BUILD_NUM} --charts production/helm/loki-stack --config=production/helm/ct.yaml
Linting charts...
Error: Invalid Semantic Version
Invalid Semantic Version

Exited with code exit status 1
CircleCI received exit code 1

I couldn't figure out which version it is comlaining about.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit b581712 into grafana:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Helm] Makefile does not work with helm v3
3 participants