Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizes SampleExpr to remove unnecessary line_format. #3065

Merged

Commits on Dec 10, 2020

  1. Optimizes SampleExpr to remove unnessary line_format.

    When doing count_over_time and rate(), it doesn't make sense to have a line_format since you're counting line, you don't really care about what the line contains.
    
    At the same time this set the foundation of for further optimization, like parsing only required labels during label parsing.
    
    I've also found a bug where `topk by(foo) (1...` where not correctly parsed.
    
    Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    cyriltovena committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    5a874a4 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. For all range vector operations.

    Except for bytes one which count bytes in lines.
    
    Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    cyriltovena committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    ae5ae00 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Update pkg/logql/optimize_test.go

    Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
    cyriltovena and owen-d authored Jan 5, 2021
    Configuration menu
    Copy the full SHA
    b937cae View commit details
    Browse the repository at this point in the history