Integrates label replace into sharding code #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3132 +/- ##
==========================================
+ Coverage 63.10% 63.14% +0.03%
==========================================
Files 188 188
Lines 16189 16197 +8
==========================================
+ Hits 10216 10227 +11
+ Misses 5034 5032 -2
+ Partials 939 938 -1
|
This reverts commit 2f34dea.
…g bug in the control case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using label replace in sharded queries willl no longer error in the shardmapper parsing stage and we will avoid running label replaces at the edge to prevent breaking associativity guarantees in upper aggregations. However, the vector expressions within a label replace function can still be sharded.