Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates alerting docs post 2.0 #3164

Merged
merged 2 commits into from
Jan 12, 2021
Merged

updates alerting docs post 2.0 #3164

merged 2 commits into from
Jan 12, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jan 12, 2021

No description provided.

slim-bean
slim-bean approved these changes Jan 12, 2021
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

slim-bean
slim-bean approved these changes Jan 12, 2021
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mattmendick
mattmendick approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@mattmendick mattmendick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One point though - I think the example query you gave looks for queries longer than 1s instead of 10s discussed in the description.

@codecov-io
Copy link

codecov-io commented Jan 12, 2021 •
edited
Loading

Codecov Report

Merging #3164 (c43141d) into master (1f6fd5e) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3164      +/-   ##
==========================================
- Coverage   63.34%   63.26%   -0.08%     
==========================================
  Files         188      188              
  Lines       16304    16304              
==========================================
- Hits        10327    10314      -13     
- Misses       5036     5050      +14     
+ Partials      941      940       -1
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/ingester/transfer.go 60.14% <0.00%> (-1.45%) ⬇️

@owen-d
Copy link
Member Author

owen-d commented Jan 12, 2021

Nice catch @mattmendick !

@owen-d owen-d merged commit 322e4bc into grafana:master Jan 12, 2021
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
@sandeepsukhani @pracucci
add store method for getting fetcher for a chunk (grafana#3164)
11f5407 
* add store method for getting fetcher for a chunk

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* add validation in schema to have from time in increasing other, accept a single timestamp for getting chunk fetcher

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* suggested change from PR review

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* Update pkg/chunk/composite_store.go

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

@mattmendick mattmendick mattmendick approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owen-d @codecov-io @mattmendick @slim-bean