Improves checkpointerWriter memory usage #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allows to find information about received size and total entries per tenant. Example of a log from my dev testing: ``` level=debug ts=2021-01-15T11:16:21.735663076Z caller=http.go:67 org_id=3927 traceID=11c4774c6ec4bbf4 msg="push request parsed" path=/loki/api/v1/push content-type=application/x-protobuf body-size="11 kB" streams=5 entries=298 streamLabelsSize="1.9 kB" entriesSize="45 kB" totalSize="47 kB" ``` Of course this means we can use LogQL on this. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
commented
Jan 18, 2021
|
|
||
| // 1MB | ||
| if w.bufSize > 1>>20 { | ||
| if w.bufSize > 1<<20 { |
kavirajk
reviewed
Jan 18, 2021
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3188 +/- ##
==========================================
- Coverage 63.33% 63.27% -0.06%
==========================================
Files 191 191
Lines 16455 16462 +7
==========================================
- Hits 10421 10417 -4
- Misses 5089 5102 +13
+ Partials 945 943 -2
|
owen-d
approved these changes
Jan 20, 2021
| if cap(buf) < size+1 { | ||
| buf = make([]byte, size+1) | ||
| } | ||
| _, err := m.MarshalTo(buf[1 : size+1]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've improve marshalling and pooling to reduce memory usage. I've also fixes a small mistake (
1>>20 =0).I've also added some more debug logs, I want to see how many each series weight and at what size do we actually flush them.
benchmp: