limit query range in async store for ingesters when query-ingesters-within flag is set #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
reviewed
Jan 20, 2021
sandeepsukhani
force-pushed
the
ingester-query-within-async-store
branch
from
0c33e27 to
3b5e8c7
Compare
owen-d
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using boltdb-shipper we do an extra query(GetChunkIDs) to ingesters to get ids of chunks from their local store which otherwise would lead to missing data in query response due to a delay in ingesters uploading their local index and queriers syncing them. We were always querying the ingesters for whole query duration without considering
query-ingesters-withinflag.In this PR we are changing the behaviour by limiting the
GetChunkIDsquery range whenquery-ingesters-withinflag is non-zero. Considering the working ofboltdb-shipperwe calculate the value for query ingesters within forGetChunkIDsqueries as follows:MaxValueOf(
querier.query-ingesters-within,ingester.max-chunk-age+boltdb shipper files upload interval+boltdb.shipper.resync-interval+15 mins).