Distributor: Loki API can receive gzipped JSON #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3291 +/- ##
==========================================
- Coverage 62.64% 62.62% -0.03%
==========================================
Files 201 201
Lines 17110 17123 +13
==========================================
+ Hits 10719 10723 +4
- Misses 5431 5442 +11
+ Partials 960 958 -2
|
ukolovda
changed the title
cyriltovena
reviewed
Feb 5, 2021
| @@ -97,6 +117,7 @@ func ParseRequest(r *http.Request) (*logproto.PushRequest, error) { | |||
| "msg", "push request parsed", | |||
| "path", r.URL.Path, | |||
| "contentType", contentType, | |||
| "contentEncoding", contentEncoding, | |||
owen-d
approved these changes
Feb 5, 2021
There was a problem hiding this comment.
This looks great, thanks!
I notice we don't have an http_test.go file, so I won't ask that you include some additional testing for this unless you'd like to.
Follow ups for @cyriltovena & myself:
- use gzip pools
- test gzip endcoded proto & json bodies
Thank you! |
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Feb 15, 2021
* Push API recognize HTTP header "Content-Encoding: gzip" and upload gzipped JSON * Fix documentation mistake
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allow send gzipped
JSONto push endpoint.HTTP server recognize
Content-Encoding: gziprequest header (for JSON only) and unpack request body.This option can reduce network traffic (5-30 times) and can be useful for sending logs to remote server.
Which issue(s) this PR fixes:
Fixes #3205
Special notes for your reviewer:
Checklist