Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Architecture Diagram #3526

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Added Architecture Diagram #3526

merged 3 commits into from
Apr 8, 2021

Conversation

wardbekker
Copy link
Member

@wardbekker wardbekker commented Mar 23, 2021

What this PR does / why we need it:

Added Loki Architecture Diagram

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sandeepsukhani can you confirm we don't use the index cache from the ingesters anymore with boltdb-shipper?

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diagram looks really good. Just a couple of feedbacks:

  1. What does Q mean in the Ruler and Querier block?
  2. I think we should point Compactor to the index store with both Read and Write arrows.
  3. We support Redis as well for caching so maybe we should add that as well.

@owen-d
Copy link
Member

owen-d commented Mar 24, 2021

The Q means the ruler embeds a querier as a subcomponent.

@sandeepsukhani
Copy link
Contributor

The Q means the ruler embeds a querier as a subcomponent.

Ahh. Sorry, it was confusing to me. What do you folks think about removing it? I think it is more of an implementation detail but I do not strongly oppose keeping it.

@wardbekker The Q on the Ruler component looks a little out of alignment too. Can you please take care of it too if we decide to keep it?

@owen-d
Copy link
Member

owen-d commented Apr 8, 2021

I think this is a good starter - we can improve in the future, but I dont' want to hold this up.

@owen-d owen-d merged commit 46eff3c into master Apr 8, 2021
@owen-d owen-d deleted the wardbekker-architecture-diagram branch April 8, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants