Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogQL Docs: Remove key-value pair missing from logfmt output #3555

Merged
merged 1 commit into from
Mar 30, 2021
Merged

LogQL Docs: Remove key-value pair missing from logfmt output #3555

merged 1 commit into from
Mar 30, 2021

Conversation

samjewell
Copy link
Contributor

As per PR title. Also fix typo

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@samjewell samjewell requested a review from adityacs March 30, 2021 09:27
sandeepsukhani
sandeepsukhani approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!
Can you please sign the CLA so that this can be merged?

@samjewell samjewell removed the request for review from adityacs March 30, 2021 09:34
@cyriltovena cyriltovena merged commit 87ca7a4 into master Mar 30, 2021
@cyriltovena cyriltovena deleted the sj/logql-docs-fixes branch March 30, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeepsukhani sandeepsukhani sandeepsukhani approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samjewell @CLAassistant @sandeepsukhani @cyriltovena