Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy loki with Drone plugin instead of CircleCI job #3708

Merged
merged 1 commit into from
May 10, 2021

Conversation

julienduchesne
Copy link
Member

We are deprecating the CircleCI job
Also, moved secrets to Vault instead of Drone

Note that this will require Flux in all environments that are updated

Issue: grafana/deployment_tools#5307

@CLAassistant
Copy link

CLAassistant commented May 10, 2021

CLA assistant check
All committers have signed the CLA.

@julienduchesne julienduchesne force-pushed the julienduchesne/update-image-with-drone-plugin branch 2 times, most recently from 9de445c to ed85e73 Compare May 10, 2021 14:52
We are deprecating the CircleCI job
Also, I moved secrets to Vault instead of Drone repository secrets

Note that this will require Flux in all environments that are updated

Issue: grafana/deployment_tools#5307
@julienduchesne julienduchesne force-pushed the julienduchesne/update-image-with-drone-plugin branch from ed85e73 to 09a46cc Compare May 10, 2021 14:53
@julienduchesne
Copy link
Member Author

@julienduchesne julienduchesne marked this pull request as ready for review May 10, 2021 14:56
@julienduchesne julienduchesne requested review from a team and dannykopping May 10, 2021 14:56
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit bbb82b5 into main May 10, 2021
@cyriltovena cyriltovena deleted the julienduchesne/update-image-with-drone-plugin branch May 10, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants