Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs deletion fixes #3827

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Logs deletion fixes #3827

merged 3 commits into from
Jun 9, 2021

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
A couple of minor fixes:

  1. Fix temp file name used for uploading delete requests table
  2. Log error on failure in removing the temp file used for uploading delete requests table, only when the error is not os.IsNotExist
  3. fix the CLI flag for delete requests cancellation period

cyriltovena
cyriltovena approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepsukhani sandeepsukhani merged commit cd38e98 into grafana:main Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandeepsukhani @cyriltovena