Querier/Ingester: Fixing json expression parser bug #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
owen-d
approved these changes
Jul 1, 2021
added 2 commits
July 1, 2021 13:33
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
|
Note: I've pulled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a tight loop in the JSON expression lexer, which results from unexpected input.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
We discovered that a query with a JSON expression like
{stream="foo"} | json key="something.["elsecaused our ingesters to crash (because we were searching for recent data - it'd crashed queriers if for older data).This bug occurred because we only break out of the scan loop if a string is terminated
"or a closing bracket is found]- but we don't check for a null byte or EOF which both indicate end of input.Checklist