Filter instant queries and shard them. #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeschkies
commented
Jul 12, 2021
jeschkies
commented
Jul 13, 2021
Comment on lines
108
to
116
| var params logql.Params | ||
| var path string | ||
| switch r.(type) { | ||
| case *LokiRequest: | ||
| params = paramsFromRequest(r) | ||
| path = r.(*LokiRequest).GetPath() | ||
| case *LokiInstantRequest: | ||
| params = paramsFromInstantRequest(r) | ||
| path = r.(*LokiInstantRequest).GetPath() |
There was a problem hiding this comment.
I wish LokiRequest and LokiInstantRequest would simply implement Params. It's almost the same.
jeschkies
commented
Jul 13, 2021
owen-d
reviewed
Jul 14, 2021
cyriltovena
reviewed
Jul 19, 2021
cyriltovena
reviewed
Jul 19, 2021
Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
jeschkies
commented
Jul 20, 2021
owen-d
reviewed
Jul 20, 2021
| @@ -75,6 +75,48 @@ func (r *LokiRequest) LogToSpan(sp opentracing.Span) { | |||
|
|
|||
| func (*LokiRequest) GetCachingOptions() (res queryrange.CachingOptions) { return } | |||
|
|
|||
| func (r *LokiInstantRequest) GetStep() int64 { | |||
There was a problem hiding this comment.
nit for later: we can probably serialize a lot of these methods into an embedded struct for reuse
There was a problem hiding this comment.
What do you mean?
| @@ -426,3 +448,45 @@ func NewMetricTripperware( | |||
| return next | |||
| }, c, nil | |||
| } | |||
|
|
|||
| // NewInstantMetricTripperware creates a new frontend tripperware responsible for handling metric queries | |||
| func NewInstantMetricTripperware( | |||
There was a problem hiding this comment.
Can we not use the ResultsCacheMiddleware like we do in the metric tripperware?
|
Alright. It's working! We've got a speed up of almost one magnitude! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This patch also enables query sharding for instant queries in addition to the range query sharding.
Checklist