Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruler: implementing write relabelling on recording rule samples #4048

Merged

Conversation

dannykopping
Copy link
Contributor

What this PR does / why we need it:
Applies write_relabel_configs if defined

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
I missed this somehow in the original implementation.

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@dannykopping dannykopping requested a review from a team as a code owner July 26, 2021 15:41
@dannykopping dannykopping changed the title Implementing write relabelling Ruler: implementing write relabelling on recording rule samples Jul 26, 2021
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint then LGTM

Danny Kopping added 2 commits July 26, 2021 17:51
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@dannykopping dannykopping merged commit 0c6b4dc into grafana:main Jul 26, 2021
cyriltovena pushed a commit that referenced this pull request Aug 3, 2021
* Implementing write relabelling

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>

* Appeasing the linter

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>

* Appeasing the linter

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants