Cleanup/unordered writes ingester config #4192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
ingester.unordered-writes-enabled
config. This has been entirely replaced by the per tenant limit configuration.out_of_order
errors when replaying a WAL after moving fromunordered_writes: true
->unordered_writes: false
. It does this by ensuring all the internals accept unordered writes during WAL replay and switches any differences at the end.loki_ingester_limiter_enabled
, which reports when it's enabled/disabled. This should help debugging as it overrides some of the embedded overrides, particularly to disable them during WAL replay.