better per stream rate limits configuration options #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
force-pushed
the
bump/per-stream-defaults
branch
from
983f183 to
8df7fb2
Compare
KMiller-Grafana
approved these changes
Aug 30, 2021
owen-d
force-pushed
the
bump/per-stream-defaults
branch
from
e6e3b45 to
a9314b4
Compare
|
ref #1544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part one of a two phase PR moving
max_stream_rate_bytes -> per_stream_rate_limitand
max_stream_burst_rate_bytes -> per_stream_rate_limit_burstI'm doing this before we release 2.4 in order to move towards more intuitive field names and in the case of the burst configs, a more accurate name (the
burstis a static value determining how far "ahead" of the rate limit a stream may be).The followup PR will remove the deprecated field entirely (to be timed with the next
k-branchcutting).