Update loki-build-image to drone 1.4.0 #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callum Styan <callumstyan@gmail.com>
|
Have you push the new image ? |
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
|
I don't think drone will pick up the new build if you don;t |
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Yes good point. I wanted to save the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that something that should have been idempotent (running
BUILD_IN_CONTAINER=false make drone) was resulting in changes todrone.ymlwhen there were no changes to the jsonnet. The drone CLI version we're using is nearly 2y old and the change we need is in more recent releases.It might also be a good idea to check for the same version that the image is using if the user uses
BUILD_IN_CONTAINER=false make droneinstead of justmake drone, thoughts?Signed-off-by: Callum Styan callumstyan@gmail.com