Fix drone ECR publish. #4541
Merged
Fix drone ECR publish. #4541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ish issues. Signed-off-by: Callum Styan <callumstyan@gmail.com>
owen-d
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere with my forked drone ECR plugin there's an issue with passing the
registry+repovalue to the base drone docker plugin asreposo that thedocker pushstep attempts to publish the image to the correct repo (ECR instead of a docker hub repo).It's not immediately clear what the cause of the problem is, since I don't think I changed anything in the plugin that would cause this, but the change in this PR works as a workaround for now.
Signed-off-by: Callum Styan callumstyan@gmail.com