Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduces "entry too far behind" instrumentation for unordered writes #4592

Merged
merged 1 commit into from
Oct 29, 2021
Merged

introduces "entry too far behind" instrumentation for unordered writes #4592

merged 1 commit into from
Oct 29, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Oct 29, 2021

This distinguishes between out of order errors (when running with unordered_writes: false) and too far behind ( unordered_writes: true), for both metrics & errors.

ref #1544

@owen-d owen-d requested a review from a team as a code owner October 29, 2021 14:43
dannykopping
dannykopping approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@owen-d owen-d merged commit cd80bc5 into grafana:main Oct 29, 2021
@owen-d owen-d mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannykopping dannykopping dannykopping approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owen-d @dannykopping