Default wal to enabled in jsonnet lib #4629
Conversation
| query_scheduler_enabled: false, | ||
| overrides_exporter_enabled: false, | ||
|
|
||
| // flags for running ingesters/queriers as a statefulset instead of deployment type. | ||
| // WAL enabled configurations automatically use statefulsets. |
There was a problem hiding this comment.
I'm not sure what this comment is saying?
There was a problem hiding this comment.
The jsonnet lib tries to detect if a WAL is being used and if so, use k8s statefulsets instead of deployments and I wanted to leave a note that mentioned this explicitly. The relevant code I'm referring to is here: https://github.com/grafana/loki/blob/main/production/ksonnet/loki/wal.libsonnet#L7
There was a problem hiding this comment.
Okay. with the line above it's ambiguous if its something that requires stateful queriers (vs just ingesters).
There was a problem hiding this comment.
The comment precedes the stateful_ingesters line, which is what it's actually commenting (I also find the github display for this a bit weird):
Followup to #4624 now that the wal is an enabled configuration by default.