Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package logcli as rpm and deb. #4667

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Conversation

jeschkies
Copy link
Contributor

@jeschkies jeschkies commented Nov 5, 2021

Summary:
This patch introduces native packages for Linux of logcli. We use nfpm since it has no dependencies and opens the door to migrate to goreleaser.

For starters only Debian and RPM packages for amd64 are supported.

Outstanding:

  • Sign packages.
  • Publish packages to GitHub releases.
  • Set proper version.
  • Run in release pipeline.
  • Optionally test package installation.

nfpm.yaml Outdated
It facilitates running LogQL queries against a Loki instance.
vendor: "Grafana Labs Inc"
homepage: "https://grafana.com/loki"
license: "AGPL-3.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually the logcli license?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @slim-bean

I think so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @slim-bean

@jeschkies jeschkies changed the title Package logcli as rpm, deb and apk. Package logcli as rpm and deb. Nov 8, 2021
nfpm.yaml Outdated Show resolved Hide resolved
@dannykopping dannykopping removed their request for review November 29, 2021 07:00
@stale
Copy link

stale bot commented Jan 8, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jan 8, 2022
@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jan 17, 2022
@jeschkies jeschkies marked this pull request as ready for review January 17, 2022 14:28
@jeschkies jeschkies requested a review from a team as a code owner January 17, 2022 14:28
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

name: "logcli"
arch: "amd64"
platform: "linux"
version: ${CIRCLE_TAG}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is CIRCLE_TAG and where is it defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's provided by the Circle CI job (https://circleci.com/docs/2.0/env-vars/#built-in-environment-variables). It's already used by tools/release-note.md and tools/release.

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. logcli isn't in our clients dir, meaning it's not Apache2 currently.

@owen-d owen-d merged commit b03e278 into grafana:main Jan 18, 2022
@jeschkies jeschkies deleted the karsten/logcli-rpm branch January 18, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants