-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package logcli as rpm and deb. #4667
Conversation
nfpm.yaml
Outdated
It facilitates running LogQL queries against a Loki instance. | ||
vendor: "Grafana Labs Inc" | ||
homepage: "https://grafana.com/loki" | ||
license: "AGPL-3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually the logcli license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @slim-bean
I think so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @slim-bean
Hi! This issue has been automatically marked as stale because it has not had any We use a stalebot among other tools to help manage the state of issues in this project. Stalebots are also emotionless and cruel and can close issues which are still very relevant. If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry. We regularly sort for closed issues which have a We may also:
We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
name: "logcli" | ||
arch: "amd64" | ||
platform: "linux" | ||
version: ${CIRCLE_TAG} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is CIRCLE_TAG
and where is it defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's provided by the Circle CI job (https://circleci.com/docs/2.0/env-vars/#built-in-environment-variables). It's already used by tools/release-note.md
and tools/release
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. logcli
isn't in our clients dir, meaning it's not Apache2 currently.
Summary:
This patch introduces native packages for Linux of
logcli
. We usenfpm
since it has no dependencies and opens the door to migrate to goreleaser.For starters only Debian and RPM packages for amd64 are supported.
Outstanding:
Sign packages.Optionally test package installation.