-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[optimization] cache prometheus : fix "loki_cache_request_duration_seconds_bucket" ‘status_code’ label always equals "200" #4891
Conversation
…conds_bucket" ‘status_code’ label always equals "200"
…conds_bucket" ‘status_code’ label always equals "200" grafana#4891
…conds_bucket" ‘status_code’ label always equals "200" grafana#4891
…conds_bucket" ‘status_code’ label always equals "200" grafana#4891
…conds_bucket" ‘status_code’ label always equals "200" grafana#4891
Hi! This issue has been automatically marked as stale because it has not had any We use a stalebot among other tools to help manage the state of issues in this project. Stalebots are also emotionless and cruel and can close issues which are still very relevant. If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry. We regularly sort for closed issues which have a We may also:
We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I just cannot find where the error metric is increased or HTTP 5xx
is returned.
Co-authored-by: Karsten Jeschkies <k@jeschkies.xyz>
…conds_bucket" ‘status_code’ label always equals "200" grafana#4891
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I'm happy to merge this once the merge conflicts/etc are addressed.
…conds_bucket" ‘status_code’ label always equals "200" grafana#4891
…conds_bucket" ‘status_code’ label always equals "200" grafana#4891
done,thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion, then LGTM. Thanks for all the great contributions!
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
refer issue :#4862
alert promql.