Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Upgrade to latest Cortex #5085

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Chore: Upgrade to latest Cortex #5085

merged 4 commits into from
Jan 10, 2022

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jan 10, 2022 •
edited
Loading

What this PR does / why we need it:
Upgrade to Cortex@e0807c4eb487 and Prometheus@692a54649ed7.

Should I add changelog entries based on what changed in dependencies?

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • [na] Documentation added
  • [na] Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@aknuds1
Chore: Upgrade to latest Cortex
10a5679 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1
Chore: Upgrade to Prometheus@692a54649ed7
96dde89 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1
Fix build after upgrading dskit
1da33d4 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 marked this pull request as ready for review January 10, 2022 10:15
@aknuds1 aknuds1 requested a review from a team as a code owner January 10, 2022 10:15
dannykopping
dannykopping approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aknuds1 👍

chaudum
chaudum approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@dannykopping dannykopping marked this pull request as draft January 10, 2022 10:45
@aknuds1
Add changelog entry
3f1e9c3 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 marked this pull request as ready for review January 10, 2022 10:46
@dannykopping dannykopping marked this pull request as draft January 10, 2022 10:47
kavirajk
kavirajk approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kavirajk kavirajk marked this pull request as ready for review January 10, 2022 11:48
@dannykopping dannykopping merged commit d87dbf9 into main Jan 10, 2022
@dannykopping dannykopping deleted the chore/upgrade-cortex branch January 10, 2022 11:57
@trevorwhitney trevorwhitney mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavirajk kavirajk kavirajk approved these changes

@dannykopping dannykopping dannykopping approved these changes

@chaudum chaudum chaudum approved these changes

Assignees
No one assigned
Labels
size/XXL type/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aknuds1 @chaudum @dannykopping @kavirajk