Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly sets hash value for headblock iterator #5423

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Correctly sets hash value for headblock iterator #5423

merged 2 commits into from
Feb 17, 2022

Conversation

cyriltovena
Copy link
Contributor

What this PR does / why we need it:

When doing https://github.com/grafana/loki/pull/5289/files I actually missed to properly set the hash for headblocks.

This result in ingesters not sending the hash for really fresh data (uncut block) and so queriers will not dedupe accordingly.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@cyriltovena cyriltovena requested a review from a team as a code owner February 17, 2022 15:34
slim-bean
slim-bean approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kavirajk
kavirajk approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean
fix test missing a hash
02b65fa 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@cyriltovena cyriltovena merged commit 5d8bc61 into grafana:main Feb 17, 2022
kavirajk pushed a commit that referenced this pull request Feb 18, 2022
@cyriltovena @kavirajk
Correctly sets hash value for headblock iterator (#5423)
9c6bc8b
@kavirajk kavirajk mentioned this pull request Feb 18, 2022
Merged
3 tasks
kavirajk added a commit that referenced this pull request Feb 18, 2022
@kavirajk @cyriltovena
Patch-k85 (#5427)
3f60693 
* Correctly sets hash value for headblock iterator (#5423)

* Do not use WaitGroup context for StepEvaluator (#5425)

Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
@dannykopping dannykopping mentioned this pull request Feb 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

@kavirajk kavirajk kavirajk approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyriltovena @kavirajk @slim-bean