Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support promtail reload config #573

Closed
wants to merge 6 commits into from
Closed

Conversation

daixiang0
Copy link
Contributor

Based on comment
Fix #16

Signed-off-by: Xiang Dai 764524258@qq.com

@daixiang0 daixiang0 force-pushed the reload branch 5 times, most recently from bce1070 to 266b291 Compare May 13, 2019 06:13
@daixiang0 daixiang0 force-pushed the reload branch 16 times, most recently from 7e2094b to 40dab72 Compare May 13, 2019 09:17
@daixiang0 daixiang0 changed the title Support promtail reload config [WIP]Support promtail reload config May 13, 2019
@daixiang0 daixiang0 force-pushed the reload branch 6 times, most recently from 36e6f00 to c0380cc Compare May 13, 2019 11:55
@daixiang0 daixiang0 force-pushed the reload branch 6 times, most recently from 3675366 to 43ee199 Compare May 25, 2019 05:36
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
daixiang0 added 2 commits May 27, 2019 10:17
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
@Lysholm
Copy link

Lysholm commented Jun 13, 2019

@daixiang0: Would this also cause promtail to reload TLS client config, even if say tls_config.cert_file config is unchanged? That is what i need for promtail to work as a telemetry provider in a mTLS enabled istio mesh :)

@gouthamve gouthamve removed their request for review August 12, 2019 11:09
@daixiang0
Copy link
Contributor Author

daixiang0 commented Aug 22, 2019

@slim-bean @cyriltovena hi, mind have a look for this? If meaningful, i would update and fix conflicts.

@stale
Copy link

stale bot commented Oct 12, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Oct 12, 2019
@daixiang0
Copy link
Contributor Author

@slim-bean @cyriltovena any update?

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Oct 12, 2019
@stale
Copy link

stale bot commented Nov 11, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Nov 11, 2019
@daixiang0
Copy link
Contributor Author

@sh0rez @rfratto @slim-bean any input?

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Nov 11, 2019
@sh0rez
Copy link
Member

sh0rez commented Nov 11, 2019

Hi, we have completely refactored and rewritten the configuration framework used in the meantime, so these changes are obsolete ;)

In case this issue still needs a fix, please open a new PR :D

@sh0rez sh0rez closed this Nov 11, 2019
@daixiang0 daixiang0 deleted the reload branch November 12, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config reload endoint / signal to promtail
3 participants