Docs: Document Promtail global rate limiting #5737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KMiller-Grafana
requested review from
09jvilla,
cyriltovena,
owen-d and
dannykopping
09jvilla
requested changes
Mar 31, 2022
Co-authored-by: Jennifer Villa <jvilla2013@gmail.com>
dannykopping
reviewed
Apr 1, 2022
| @@ -1756,6 +1759,26 @@ scrape_configs: | |||
| target_label: 'container' | |||
| ``` | |||
|
|
|||
| ## limit_config | |||
There was a problem hiding this comment.
This looks good @KMiller-Grafana, and we should align this with the flags registered here:
https://github.com/grafana/loki/blob/main/clients/pkg/promtail/limit/config.go#L14-L19
dannykopping
approved these changes
Apr 2, 2022
liguozhong
reviewed
Apr 2, 2022
| @@ -95,6 +95,9 @@ clients: | |||
| scrape_configs: | |||
| - [<scrape_config>] | |||
|
|
|||
| # Configures global limits for this instance of Promtail | |||
| [limit_config: <limit_config>] | |||
09jvilla
requested changes
Apr 4, 2022
MasslessParticle
added
the
backport release-2.5.x
grafanabot
pushed a commit
that referenced
this pull request
Apr 7, 2022
* Docs: Document Promtail global rate limiting * Update docs/sources/clients/promtail/configuration.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> * Revise strings that explain the new configuration parameters * For rate limiting, limit_config becomes limits_config Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> (cherry picked from commit c860fc6)
MasslessParticle
pushed a commit
that referenced
this pull request
Apr 7, 2022
* Docs: Document Promtail global rate limiting * Update docs/sources/clients/promtail/configuration.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> * Revise strings that explain the new configuration parameters * For rate limiting, limit_config becomes limits_config Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> (cherry picked from commit c860fc6) Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
splitice
pushed a commit
to X4BNet/loki
that referenced
this pull request
May 21, 2022
…5814) * Docs: Document Promtail global rate limiting * Update docs/sources/clients/promtail/configuration.md Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> * Revise strings that explain the new configuration parameters * For rate limiting, limit_config becomes limits_config Co-authored-by: Jennifer Villa <jvilla2013@gmail.com> (cherry picked from commit c860fc6) Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #5730.
Reviewers: what have I missed or gotten wrong in this addition of documentation?