Revendor grafana/tail to fix promtail symlink behavior
#6034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This revendoring brings the fix to relative symlinks, as described in grafana#3374.
|
@DylanGuedes sorry I didn't think about this until after clicking merge. Can you fire up another PR and put an entry in the change log for this in the promtail section? |
4 tasks
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Revendors
grafana/tailto introduce a recent fix to how we tail symlinks. With the current implementation, promtail is only able to work with symlinks if they're in the same folder as the promtail binary; if they're inside a nested folder, tail is unable to find the files.Which issue(s) this PR fixes:
Special notes for your reviewer:
os.ReadlinkChecklist
CHANGELOG.md.docs/sources/upgrading/_index.md