Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promtail: disable syslog tests which have expired certs #6520

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Conversation

slim-bean
Copy link
Collaborator

We should create new certs to fix this, but in the meantime this is stopping every build so I'm just disabling the tests

…pired.

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean slim-bean requested a review from a team as a code owner June 27, 2022 21:28
@slim-bean slim-bean changed the title Promtail: disable tests which have expired certs Promtail: disable syslog tests which have expired certs Jun 27, 2022
Copy link
Contributor

@DylanGuedes DylanGuedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean slim-bean merged commit 2fc20af into main Jun 28, 2022
@slim-bean slim-bean deleted the disable-tests branch June 28, 2022 01:54
dannykopping pushed a commit that referenced this pull request Jun 28, 2022
* disable tests which are failing from hardcoded certs which are now expired.

Signed-off-by: Edward Welch <edward.welch@grafana.com>

* lint

Signed-off-by: Edward Welch <edward.welch@grafana.com>
johanfleury added a commit to johanfleury/loki that referenced this pull request Jun 29, 2022
chaudum pushed a commit that referenced this pull request Jun 30, 2022
* disable tests which are failing from hardcoded certs which are now expired.

Signed-off-by: Edward Welch <edward.welch@grafana.com>

* lint

Signed-off-by: Edward Welch <edward.welch@grafana.com>
chaudum pushed a commit that referenced this pull request Jun 30, 2022
* disable tests which are failing from hardcoded certs which are now expired.

Signed-off-by: Edward Welch <edward.welch@grafana.com>

* lint

Signed-off-by: Edward Welch <edward.welch@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants