Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
tags only
confusingly builds branches as welltools/image-tag
since the latter uses a prefix ofHEAD
for tags which does not exist in Docker hub. This should be fine for now unless you guys ever tag from a different branchloki-docker-driver
not usingIMAGE_PREFIX
, making it impossible to run in my own CIrcleCIWhich issue(s) this PR fixes:
Special notes for your reviewer:
You can see proof that it works here:
https://circleci.com/gh/steven-sheehy/loki/524
https://github.com/steven-sheehy/loki/releases
Checklist