Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release workflow #677

Closed
wants to merge 2 commits into from
Closed

Conversation

steven-sheehy
Copy link
Contributor

@steven-sheehy steven-sheehy commented Jun 18, 2019

What this PR does / why we need it:

  • Re-enables the release workflow disabled in release stage is broken, removing for now #647
  • Main fix was to add ignore branches since by default tags only confusingly builds branches as well
  • Docker tag is hardcoded to master instead of tools/image-tag since the latter uses a prefix of HEAD for tags which does not exist in Docker hub. This should be fine for now unless you guys ever tag from a different branch
  • Change helm chart to publish only on a tag
  • Fix loki-docker-driver not using IMAGE_PREFIX, making it impossible to run in my own CIrcleCI

Which issue(s) this PR fixes:

Special notes for your reviewer:
You can see proof that it works here:

https://circleci.com/gh/steven-sheehy/loki/524
https://github.com/steven-sheehy/loki/releases

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Steven Sheehy <ssheehy@firescope.com>
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @slim-bean I defer to you here.

@cyriltovena cyriltovena requested a review from slim-bean July 8, 2019 14:14
@slim-bean
Copy link
Collaborator

I think we covered the spirit of this PR with the latest overhaul of the circle config and makefile, so I'm gonna close this PR. Please let me know if we are missing anything @steven-sheehy

@slim-bean slim-bean closed this Aug 5, 2019
@steven-sheehy
Copy link
Contributor Author

It still publishes a helm chart on every commit and not on a tag only. This was the main purpose of the PR.

@slim-bean
Copy link
Collaborator

I created a separate issue to improve the helm chart release process #852 which also identifies some challenges we face around creating a release PR and our builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants