feat: Magefile #687
feat: Magefile #687
Conversation
Adds Build namespace with compile targets for Loki, Promtail and LogCLI
Ports lint and test targets from Makefile
Ports all helm related targets from Makefile
Adds magefile libraries required to build the build-chain
Adding targets to Makefile to install and upgrade mage. Experimenting with a `mage all` target
|
I'm liking this so far, my only gripe is that I wish you could default the I think we should continue to build out functionality. |
|
|
|
yeah true :) really I want to impose I think to keep the feel of loki similar to most go projects we should keep the makefile as a wrapper to mage, we can even go so far as adding the new I think we'd just have to figure out what targets to keep in the makefile |
| type Assets mg.Namespace | ||
|
|
||
| func (Assets) CheckAssets() error { | ||
| err := sh.Run("git", "diff", "--exit-code", "pkg/promtail/server/ui") |
There was a problem hiding this comment.
git() is available as a function (cmds.go)
|
@sh0rez What was the end result of this experiment? We're contemplating investing in Mage to help with compatibility issues with Makefile and supporting devs on Windows/Max/Linux |
|
We went with Makefiles instead, mostly because shelling out in Go is not optimal, as it requires error checking, etc. But I am aware of many projects being very happy with Mage and it is by far the best Make alternative I have seen so far. |
|
Understood, thanks for the quick response! |
Adds a
magefile.goas an exploratory effort whether it is worth it investing on that technology. Not intended to be merged yet. See #684 for referenceProgress overview:
allassetsbuild-plugincheck_assetscheck-generated-filescleancmd/docker-driver/docker-drivercmd/docker-driver/docker-driver-debugcmd/docker-driver/.uptodatecmd/docker-driver/.uptodate-debugcmd/logcli/logcli(renamed tobuild:logcli)cmd/logcli/logcli-debug(renamed toDEBUG=true build:logcli)cmd/logcli/.uptodatecmd/logcli/.uptodate-debugcmd/loki/loki(renamed tobuild:loki)cmd/loki/loki-debug(renamed toDEBUG=true build:loki)cmd/loki/.uptodatecmd/loki/.uptodate-debugcmd/promtail/promtail(renamed tobuild:logcli)cmd/promtail/promtail-debug(renamed toDEBUG=true build:loki)cmd/promtail/.uptodatecmd/promtail/.uptodate-debugdebugenable-pluginhelm(renamed tohelm:build)helm-cleanhelm-installhelm-publishhelm-upgradeimageslintload-imagesloki-build-image/.uptodatepkg/logproto/logproto.pb.gopkg/logql/expr.gopkg/promtail/server/server.goprotospush-imagespush-latestpush-pluginrelease-performrelease-preparesave-imagesshelltestvendor/github.com/cortexproject/cortex/pkg/chunk/storage/caching_index_client.pb.govendor/github.com/cortexproject/cortex/pkg/ingester/client/cortex.pb.govendor/github.com/cortexproject/cortex/pkg/ring/ring.pb.goyacc