Backport 7804 into 2.7.1 #7896
Merged
Backport 7804 into 2.7.1 #7896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
trevorwhitney
changed the base branch from
backport-7804-to-release-2.7.x
to
release-2.7.x
… data requested for deletion (grafana#7804) **What this PR does / why we need it**: Add grpc support to compactor for getting delete requests and gen number for query time filtering. Since these requests are internal to Loki, it would be good to use grpc instead of HTTP same as all the internal requests we do in Loki. I have added a new config for accepting the grpc address of the compactor. I tried having just the existing config and detecting if it is a grpc server, but it was hard to do it reliably, considering the different deployment modes we support. I think it is safe to keep it the same and eventually deprecate the existing config. **Checklist** - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated (cherry picked from commit 1410808)
**What this PR does / why we need it**: I had enabled auto-merge in PR grafana#7804, but somehow it still merged the PR without all the checks passing. This PR fixes the failing lint and tests.
trevorwhitney
force-pushed
the
backport-7804-to-release-2.7.x
branch
from
48514cf to
a591ad7
Compare
MasslessParticle
approved these changes
Dec 9, 2022
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. - ingester -0.5%
- distributor -0.8%
- querier -0.1%
- querier/queryrange -1.1%
+ iter 0%
+ storage 0.2%
+ chunkenc 0%
+ logql 1.7%
+ loki 0.5% |
trevorwhitney
added a commit
to trevorwhitney/loki
that referenced
this pull request
Dec 9, 2022
This reverts commit e0af1cc.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use grpc for communicating with compactor for query time filtering of data requested for deletion (#7804)
Manual backport of #7804 and #7814
What this PR does / why we need it:
Add grpc support to compactor for getting delete requests and gen number for query time filtering.
Since these requests are internal to Loki, it would be good to use grpc instead of HTTP same as all the internal requests we do in Loki.
I have added a new config for accepting the grpc address of the compactor. I tried having just the existing config and detecting if it is a grpc server, but it was hard to do it reliably, considering the different deployment modes we support. I think it is safe to keep it the same and eventually deprecate the existing config.
Checklist
CHANGELOG.mdupdated(cherry picked from commit 1410808)