Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update read dashboard to include only query and label query routes #867

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Update read dashboard to include only query and label query routes #867

merged 2 commits into from
Aug 7, 2019

Conversation

slim-bean
Copy link
Collaborator

Also removed the loki-frontend dashboard as it only has one panel which is duplicated in loki-reads

@slim-bean
sum the read dashboard by route and make sure we are only showing que…
e6c8f18 
…ry and label routes (not tail)
@slim-bean
Removing the loki-frontend dashboard as it only has one panel which i…
b50bdda 
…s duplicated in the loki-reads panel, we can bring it back when add more to the loki frontend.
@slim-bean slim-bean requested a review from cyriltovena August 7, 2019 18:01
cyriltovena
cyriltovena approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit 4354f80 into master Aug 7, 2019
@rfratto rfratto deleted the update-read-dashboard branch November 1, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slim-bean @cyriltovena