Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline: Fixed labels process test with same objects #869

Merged
merged 2 commits into from
Aug 8, 2019
Merged

Pipeline: Fixed labels process test with same objects #869

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fc4241
Fixed labels process test with same objects
jojohappy Aug 8, 2019
8c345b5
Swap the comparison objects
jojohappy Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/logentry/stages/labels_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func TestLabelStage_Process(t *testing.T) {
t.Fatal(err)
}
st.Process(test.inputLabels, test.extractedData, nil, nil)
assert.Equal(t, test.expectedLabels, test.expectedLabels)
assert.Equal(t, test.inputLabels, test.expectedLabels)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you swap these around?

func Equal(t TestingT, expected, actual interface{}, msgAndArgs ...interface{})

So that test.expectedLabels is first and test.inputLabels is second, this will make any failure messages a little easier to understand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

})
}
}