operator: Enable Route by default on OpenShift clusters #9346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminesnow
approved these changes
May 2, 2023
xperimental
reviewed
May 4, 2023
xperimental
reviewed
May 5, 2023
There was a problem hiding this comment.
I can still find two references of gatewayRoute:
- in
feature_gates.md(needs amake web-pre) - in
config.grafana.com_projectconfigs.yaml
The second one seems to be an old reference that has not been updated in a while. I currently do not remember how to update that file... Is it possible that we generated that file once "by accident" and did not delete it afterwards?
The generate YAML file is actually obsolete as per this CRD is not used for the API. However kubebuilder/operator-sdk generated this file initially. |
xperimental
approved these changes
May 8, 2023
periklis
added a commit
to periklis/loki
that referenced
this pull request
May 23, 2023
periklis
added a commit
to periklis/loki
that referenced
this pull request
May 23, 2023
periklis
added a commit
to openshift/loki
that referenced
this pull request
May 23, 2023
[release-5.7] Backport PR grafana#9346
periklis
added a commit
to openshift/loki
that referenced
this pull request
May 23, 2023
[release-5.6] Backport PR grafana#9346
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With the availability of the
community-openshift(See #8881) bundle we control all available hubs for OpenShift clusters. Thus we can assume that a user using either theredhat-openshift-ecosystem/community-operators-prodhub or the RedHat internal catalogs installs this Operator on an OpenShift clusters. Therefore we can always assume that the following facilities are available:This PR decouples reconciling a Route and a CABundle ConfigMap from the user selection of tenant mode. Formerly the user had to select either tenant mode
openshift-loggingoropenshift-networkto inform the operator that the hosting cluster is OpenShift. In the proposed change the cluster flavor is controlled automatically via the bundled feature gates configuration.In addition this enables using the tenant modes
staticanddynamicwith public OIDC providers via the route.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.md