fix json expression parser #9410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
approved these changes
May 5, 2023
MasslessParticle
added a commit
that referenced
this pull request
May 5, 2023
When the value parsed by the `JsonExpressionParser` is an escaped json
string, the result still contains escape character and may not be valid
json. This causes subsequent json parsing steps to fail. For example:
`{app="foo"} | json message | line_format "{{.message}}" | json` fails
when `message` remains escaped.
This PR unescapes the results of extracted `JsonExpressions` so they can
be parsed by subsequent json parsers
MasslessParticle
added a commit
that referenced
this pull request
May 5, 2023
6 tasks
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the value parsed by the
JsonExpressionParseris an escaped json string, the result still contains escape character and may not be valid json. This causes subsequent json parsing steps to fail. For example:{app="foo"} | json message | line_format "{{.message}}" | jsonfails whenmessageremains escaped.This PR unescapes the results of extracted
JsonExpressionsso they can be parsed by subsequent json parsers